Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate tracer with task manager #80721

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Integrate tracer with task manager #80721

merged 6 commits into from
Nov 15, 2021

Conversation

DaveCTurner
Copy link
Contributor

No description provided.

@DaveCTurner DaveCTurner requested a review from tlrx November 15, 2021 14:47
@DaveCTurner DaveCTurner added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement labels Nov 15, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 15, 2021
tlrx
tlrx approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/src/main/java/org/elasticsearch/tasks/TaskTracer.java Outdated
assert false : e;
logger.warn(
new ParameterizedMessage(
"task tracing listener [{}] failed on registration of task [{}][{}]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"task tracing listener [{}] failed on registration of task [{}][{}]",
"task tracing listener [{}] failed on unregistration of task [{}][{}]",

@DaveCTurner
Copy link
Contributor Author

@elasticmachine please run elasticsearch-ci/part-1

@DaveCTurner
Copy link
Contributor Author

@elasticmachine please run elasticsearch-ci/part-2

1 similar comment
@DaveCTurner
Copy link
Contributor Author

@elasticmachine please run elasticsearch-ci/part-2

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 15, 2021
@elasticsearchmachine elasticsearchmachine merged commit ba34d70 into elastic:feature/apm-integration Nov 15, 2021
@DaveCTurner DaveCTurner deleted the 2021-11-15-apm-integration-task-tracer branch November 15, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrx tlrx tlrx approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaveCTurner @tlrx @elasticmachine @elasticsearchmachine