Minimize search source of shard level search requests #80634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
v8.0.0
v7.16.1
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
jimczi
reviewed
Nov 15, 2021
server/src/main/java/org/elasticsearch/search/builder/SearchSourceBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/internal/ShardSearchRequest.java
Outdated
Show resolved
Hide resolved
|
@jimczi I've addressed your comments. Can you take another look? Thank you! |
jimczi
reviewed
Nov 15, 2021
server/src/main/java/org/elasticsearch/search/internal/ShardSearchRequest.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
Thanks Jim! |
dnhatn
added
the
auto-backport
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 16, 2021
This change reduces the memory usage and serialization cost of shard-level search requests by discarding the point in time and collapse from search sources of these shard-level requests. Relates elastic#80187
💔 Backport failed
You can use sqren/backport to manually backport by running |
dnhatn
added a commit
that referenced
this pull request
Nov 16, 2021
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 16, 2021
This change reduces the memory usage and serialization cost of shard-level search requests by discarding the point in time and collapse from search sources of these shard-level requests. Relates elastic#80187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the memory usage and serialization cost of shard-level search requests by discarding the point in time and collapse from search sources of these shard-level requests.
I will work on another PR to remove SearchContextId from search responses.
Relates #80187