Update Gradle wrapper to 7.3 #80633
Merged
Update Gradle wrapper to 7.3 #80633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@breskeby please no rush but can you put some eyes on this? At some point |
|
I have an open pr with the latest RC before the release open that included a fix too |
|
Lgtm |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 10, 2021
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 10, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 10, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Gradle 7.3, which among other things, includes Java 17 support.
It seems at some point in the 7.3 RC process
BuildLayoutwas changed to now report the root directory as the root of the included build instead of the root of the whole composite. We now have to use some trickery to determine whether the current project is an included build or not. For simplicity I'm just using the heuristic that if this project itself includes builds, it must be the root composite, otherwise, we're an included build so look up a level. To make this consistent and work I had to changebuild-tools-internalto no longer itself be a composite, which is actually unnecessary. When buildingbuild-tools-internalas part of a larger composite the dependencies are substituted as expected.