[ML] Force stop deployment in use #80431
Conversation
Implements a `force` parameter to the stop deployment API. This allows a user to forcefully stop a deployment. Currently, this specifically allows stopping a deployment that is in use by ingest processors.
|
Pinging @elastic/ml-core (Team:ML) |
|
Pinging @elastic/clients-team (Team:Clients) |
docs/reference/ml/df-analytics/apis/stop-trained-model-deployment.asciidoc
Outdated
Show resolved
Hide resolved
| } | ||
| }, | ||
| "body":{ | ||
| "description":"The stop deployment parameters" |
There was a problem hiding this comment.
What sorts of options can be passed in the body? I don't see a request body documented for this API.
There was a problem hiding this comment.
There isn't one documented yet (it will be if we do this).
I am not a HUGE fan of this convention (its elsewhere in ES), where the query params can optionally be supplied in the body. I would much rather have one or the other, but this change does follow convention.
There was a problem hiding this comment.
Going to switch my review to approve to not be in the way, but it would be appreciated to add docs+tests for these parameters and the request body. We currently don't have this API modeled in the Elasticsearch specification and these resources help us accomplish that! 🙇♂️
It is experimental :D. So, specification might be a ways off... |
|
@benwtrent We do model experimental APIs ( |
|
@sethmlarson There is a problem with having a YML test for this API. To set up such a test we'd need to first start a deployment and that takes too long for actual models. We have a small dummy model we use for testing in |
|
run elasticsearch-ci/bwc |
|
@elasticmachine update branch |
|
run elasticsearch-ci/docs |
💔 Backport failed
You can use sqren/backport to manually backport by running |
Implements a `force` parameter to the stop deployment API. This allows a user to forcefully stop a deployment. Currently, this specifically allows stopping a deployment that is in use by ingest processors. Co-authored-by: Elastic Machine <[email protected]>
Implements a `force` parameter to the stop deployment API. This allows a user to forcefully stop a deployment. Currently, this specifically allows stopping a deployment that is in use by ingest processors. Co-authored-by: Elastic Machine <[email protected]>
|
@dimitris-athanasiou No problem! Also if only the negative cases are YAML-testable we get value from those too. |
Implements a
forceparameter to the stop deployment API.This allows a user to forcefully stop a deployment. Currently,
this specifically allows stopping a deployment that is in use
by ingest processors.