[7.16] Drop non-setting deprecations down to warning level #80374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
>non-issue
:Core/Infra/Settings
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
After this change, there will be 189 usages of org.elasticsearch.common.logging.DeprecationLogger#critical in the 7.16 branch. |
dakrone
approved these changes
Nov 9, 2021
| @@ -511,7 +511,7 @@ public void testRewriteForUpdate() throws IOException { | |||
| assertTrue(transformConfigRewritten.getSettings().getDatesAsEpochMillis()); | |||
| assertFalse(transformConfigRewritten.getSettings().getAlignCheckpoints()); | |||
|
|
|||
| assertWarnings(TransformDeprecations.ACTION_MAX_PAGE_SEARCH_SIZE_IS_DEPRECATED); | |||
| assertWarnings(org.apache.logging.log4j.Level.WARN, TransformDeprecations.ACTION_MAX_PAGE_SEARCH_SIZE_IS_DEPRECATED); | |||
There was a problem hiding this comment.
Any particular reason these are fully qualified?
There was a problem hiding this comment.
Weird .. Intellij chose to do that. Fixed in 0718f87 (#80374)
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary to #79665 this change
will reduce the deprecation logging level to WARN for (most) all non-settings that
continue to exist in 8.0+.
===
Note - I identified which logs needed to be reduced from the work at #80167. In that PR I used IntelliJ to refactor ALL deprecations in 8.0+ to log at warning level. One of those commits
967264e(#80167) that got squashed in the final merge was only for non-settings. So that commit has all of the non-settings that still exist in 8.0, so I cherry-picked that commit back to 7.16 and only merged files that merged cleanly. So there are likely a couple critical level that could be adjusted since they had additional logic that would require additional manual evaluation. I also had to update the tests since in 7.16 the default assertion is for critical, but in 8.0+ the default assertion is for warning level. There were only a few outliers and have confidence that the list here is accurate and mostly complete.