Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script: int, byte, short fields for Fields API #80316

Closed

Conversation

stu-elastic
Copy link
Contributor

  • Adds DocValuesField for int, byte and short fields

These fields are all backed by SortedNumericDocValues and use
ScriptDocValues.Longs when used via doc['myfield'] access in
painless scripts.

DocValuesField is not implemented for long because that type
backs several other mapped types and cannot be implemented at this
time.

It is stubbed out by LongDocValuesWrapper which does not implement
get(default), get(index, default) and throws an
UnsupportedOperationException for iterator()

* Adds DocValuesField for int, byte and short fields

These fields are all backed by `SortedNumericDocValues` and use
`ScriptDocValues.Longs` when used via `doc['myfield']` access in
painless scripts.

DocValuesField is not implemented for long because that type
backs several other mapped types and cannot be implemented at this
time.

It is stubbed out by `LongDocValuesWrapper` which does not implement
`get(default)`, `get(index, default)` and throws an
`UnsupportedOperationException` for `iterator()`
@stu-elastic stu-elastic added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement labels Nov 4, 2021
@stu-elastic stu-elastic marked this pull request as ready for review November 4, 2021 20:42
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Nov 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@stu-elastic stu-elastic requested a review from jdconrad November 4, 2021 20:42
@stu-elastic
Copy link
Contributor Author

Closed in favor of #81126 which uses the supplier infrastructure from #80635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants