-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Mockito to 4.0.0 #79949
Merged
Merged
Upgrade Mockito to 4.0.0 #79949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mockito 4.0 removes several deprecated methods. This commit updates usages of those deprecated methods and upgrades mockito. The changes include: * Replace anyMapOf,anyListOf,anySetOf,anyCollectionOf with the same method name without `Of` and no longer taking any arguments. * Replace anyObject with any * Removing argument from isNull * Replace verifyZeroInteractions with verifyNoMoreInteractions
rjernst
added
>test
Issues or PRs that are addressing/adding tests
:Delivery/Build
Build or test infrastructure
v7.16.1
labels
Oct 27, 2021
Pinging @elastic/es-delivery (Team:Delivery) |
grcevski
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It's great to see that we don't need the cast types anymore.
rjernst
added
v8.0.0
auto-backport-and-merge
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
labels
Oct 27, 2021
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 27, 2021
Mockito 4.0 removes several deprecated methods. This commit updates usages of those deprecated methods and upgrades mockito. The changes include: * Replace anyMapOf,anyListOf,anySetOf,anyCollectionOf with the same method name without `Of` and no longer taking any arguments. * Replace anyObject with any * Removing argument from isNull * Replace verifyZeroInteractions with verifyNoMoreInteractions The changes here were completely mechanical, done entirely with forms of find/replace within IntelliJ.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 27, 2021
Mockito 4.0 removes several deprecated methods. This commit updates usages of those deprecated methods and upgrades mockito. The changes include: * Replace anyMapOf,anyListOf,anySetOf,anyCollectionOf with the same method name without `Of` and no longer taking any arguments. * Replace anyObject with any * Removing argument from isNull * Replace verifyZeroInteractions with verifyNoMoreInteractions The changes here were completely mechanical, done entirely with forms of find/replace within IntelliJ.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 28, 2021
Mockito 4.0 removes several deprecated methods. This commit updates usages of those deprecated methods and upgrades mockito. The changes include: * Replace anyMapOf,anyListOf,anySetOf,anyCollectionOf with the same method name without `Of` and no longer taking any arguments. * Replace anyObject with any * Removing argument from isNull * Replace verifyZeroInteractions with verifyNoMoreInteractions The changes here were completely mechanical, done entirely with forms of find/replace within IntelliJ.
rjernst
added a commit
that referenced
this pull request
Oct 28, 2021
Mockito 4.0 removes several deprecated methods. This commit updates usages of those deprecated methods and upgrades mockito. The changes include: * Replace anyMapOf,anyListOf,anySetOf,anyCollectionOf with the same method name without `Of` and no longer taking any arguments. * Replace anyObject with any * Removing argument from isNull * Replace verifyZeroInteractions with verifyNoMoreInteractions The changes here were completely mechanical, done entirely with forms of find/replace within IntelliJ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Delivery/Build
Build or test infrastructure
Team:Delivery
Meta label for Delivery team
>test
Issues or PRs that are addressing/adding tests
v7.16.0
v8.0.0-beta1
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockito 4.0 removes several deprecated methods. This commit updates
usages of those deprecated methods and upgrades mockito. The changes
include:
method name without
Of
and no longer taking any arguments.The changes here were completely mechanical, done entirely with forms of find/replace within IntelliJ.