Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand warning about modifying data path contents #79649

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Expand warning about modifying data path contents #79649

merged 3 commits into from
Oct 21, 2021

Conversation

DaveCTurner
Copy link
Contributor

Today we have a short note in one place in the docs saying not to touch
the contents of the data path. This commit expands the warning to
describe more precisely what is forbidden, and to give some more detail
of the consequences, and also duplicates the warning to the other
location that documents the path.data setting.

@DaveCTurner DaveCTurner added >docs General docs changes :Core/Infra/Core Core issues without another label v8.0.0 v7.15.2 v7.16.1 labels Oct 21, 2021
@DaveCTurner
Expand warning about modifying data path contents
c87f5d0 
Today we have a short note in one place in the docs saying not to touch
the contents of the data path. This commit expands the warning to
describe more precisely what is forbidden, and to give some more detail
of the consequences, and also duplicates the warning to the other
location that documents the `path.data` setting.
@DaveCTurner DaveCTurner force-pushed the 2021-10-21-data-path-warning branch from d50b5c2 to c87f5d0 Compare October 21, 2021 18:29
@DaveCTurner DaveCTurner requested a review from jrodewig October 21, 2021 18:38
@DaveCTurner DaveCTurner marked this pull request as ready for review October 21, 2021 18:38
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Core/Infra Meta label for core/infra team labels Oct 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

jrodewig
jrodewig approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left some non-blocking nits for readability. Feel free to ignore those as wanted.

docs/reference/modules/node.asciidoc Outdated Show resolved Hide resolved
docs/reference/modules/node.asciidoc Outdated Show resolved Hide resolved
docs/reference/modules/node.asciidoc Outdated Show resolved Hide resolved
docs/reference/modules/node.asciidoc Outdated Show resolved Hide resolved
docs/reference/modules/node.asciidoc Outdated Show resolved Hide resolved
@DaveCTurner DaveCTurner added auto-backport-and-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Oct 21, 2021
@DaveCTurner
Copy link
Contributor Author

Thanks James, good suggestions as always.

@elasticsearchmachine elasticsearchmachine merged commit 6cc0a41 into elastic:master Oct 21, 2021
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 21, 2021
@DaveCTurner
Expand warning about modifying data path contents (elastic#79649)
1658207 
Today we have a short note in one place in the docs saying not to touch
the contents of the data path. This commit expands the warning to
describe more precisely what is forbidden, and to give some more detail
of the consequences, and also duplicates the warning to the other
location that documents the `path.data` setting.
@DaveCTurner DaveCTurner mentioned this pull request Oct 21, 2021
Merged
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 21, 2021
@DaveCTurner
Expand warning about modifying data path contents (elastic#79649)
0e9e595 
Today we have a short note in one place in the docs saying not to touch
the contents of the data path. This commit expands the warning to
describe more precisely what is forbidden, and to give some more detail
of the consequences, and also duplicates the warning to the other
location that documents the `path.data` setting.
@DaveCTurner DaveCTurner mentioned this pull request Oct 21, 2021
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.16

elasticsearchmachine pushed a commit that referenced this pull request Oct 21, 2021
@DaveCTurner
Expand warning about modifying data path contents (#79649) (#79655)
7468aa0 
Today we have a short note in one place in the docs saying not to touch
the contents of the data path. This commit expands the warning to
describe more precisely what is forbidden, and to give some more detail
of the consequences, and also duplicates the warning to the other
location that documents the `path.data` setting.
elasticsearchmachine pushed a commit that referenced this pull request Oct 21, 2021
@DaveCTurner
Expand warning about modifying data path contents (#79649) (#79656)
71a5b00 
Today we have a short note in one place in the docs saying not to touch
the contents of the data path. This commit expands the warning to
describe more precisely what is forbidden, and to give some more detail
of the consequences, and also duplicates the warning to the other
location that documents the `path.data` setting.
@DaveCTurner DaveCTurner deleted the 2021-10-21-data-path-warning branch October 22, 2021 08:25
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 28, 2021
@DaveCTurner
Expand warning about modifying data path contents (elastic#79649)
3ed2bd4 
Today we have a short note in one place in the docs saying not to touch
the contents of the data path. This commit expands the warning to
describe more precisely what is forbidden, and to give some more detail
of the consequences, and also duplicates the warning to the other
location that documents the `path.data` setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.15.2 v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DaveCTurner @elasticmachine @elasticsearchmachine @jrodewig @jakelandis @danhermann