Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance testKnnVectorsFormat test #79615

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Enhance testKnnVectorsFormat test #79615

merged 1 commit into from
Oct 21, 2021

Conversation

mayya-sharipova
Copy link
Contributor

Test the output of toString method as it is available now.

Relates to #79193

@mayya-sharipova
Enhance testKnnVectorsFormat test
8e47185 
Test the output of toString method as it is available now.

Relates to elastic#79193
@mayya-sharipova mayya-sharipova added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories labels Oct 21, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@mayya-sharipova mayya-sharipova added >non-issue v8.0.0 and removed Team:Search Meta label for search team labels Oct 21, 2021
jtibshirani
jtibshirani approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unusual to be asserting equality using the string representation. But I see how this is hard to check in another way (and why we want to avoid adding getters to Lucene90HnswVectorsFormat).

@mayya-sharipova
Copy link
Contributor Author

@jtibshirani Thanks for the review.

But I see how this is hard to check in another way (and why we want to avoid adding getters to Lucene90HnswVectorsFormat).

Indeed as there will be no use of these getters except this test.

@mayya-sharipova mayya-sharipova merged commit 7823e5a into elastic:master Oct 21, 2021
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 28, 2021
@mayya-sharipova
Enhance testKnnVectorsFormat test (elastic#79615)
3c1a74d 
Test the output of toString method as it is available now.

Relates to elastic#79193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtibshirani jtibshirani jtibshirani approved these changes

Assignees
No one assigned
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayya-sharipova @elasticmachine @jtibshirani @jakelandis