Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix typo #79609

Merged
merged 3 commits into from
Oct 27, 2021
Merged

[DOCS] Fix typo #79609

merged 3 commits into from
Oct 27, 2021

Conversation

sag-tobias-frey
Copy link
Contributor

@sag-tobias-frey sag-tobias-frey commented Oct 21, 2021 •
edited
Loading

@elasticsearchmachine elasticsearchmachine added v8.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 21, 2021
@cbuescher cbuescher added the >docs General docs changes label Oct 21, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Oct 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig self-requested a review October 26, 2021 22:23
jrodewig
jrodewig approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @sag-tobias-frey. I pushed a minor commit to move the recommendation to the top of the warning.

Otherwise this LGTM. I'll merge once the CI tests pass.

@jrodewig
Copy link
Contributor

@elasticmachine ok to test

@jrodewig
Copy link
Contributor

I pushed a minor commit to move the recommendation to the top of the warning.

After a second look, this actually messes up reuse in the date_nanos docs. I'll just accept your change as is. Thanks again!

@jrodewig jrodewig changed the title Correct sentence in date.asciidoc [DOCS] Fix typo Oct 27, 2021
@jrodewig jrodewig merged commit 9cddd78 into elastic:master Oct 27, 2021
This was referenced Oct 27, 2021
Merged
Merged
jrodewig added a commit that referenced this pull request Oct 27, 2021
@jrodewig @sag-tobias-frey
[DOCS] Fix typo (#79609) (#79924)
5508b14 
Co-authored-by: Tobias Frey <[email protected]>
jrodewig added a commit that referenced this pull request Oct 27, 2021
@jrodewig @sag-tobias-frey
[DOCS] Fix typo (#79609) (#79925)
201b253 
Co-authored-by: Tobias Frey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v7.15.2 v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sag-tobias-frey @elasticmachine @jrodewig @jakelandis @cbuescher @danhermann @elasticsearchmachine