Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] [7.x] Document deprecation of storing nanosecond resolution on date field #79554

Merged
merged 2 commits into from
Oct 20, 2021
Merged

[DOCS] [7.x] Document deprecation of storing nanosecond resolution on date field #79554

merged 2 commits into from
Oct 20, 2021

Conversation

pgomulka
Copy link
Contributor

relates #78921

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka pgomulka self-assigned this Oct 20, 2021
@pgomulka pgomulka requested a review from jrodewig October 20, 2021 09:13
@pgomulka pgomulka mentioned this pull request Oct 20, 2021
Closed
@pgomulka pgomulka changed the title [DOCS] Document deprecation of storing nanosecond resolution on date field [DOCS] [7.x] Document deprecation of storing nanosecond resolution on date field Oct 20, 2021
jrodewig
jrodewig approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left some additional edits as suggestions, but they're not blocking. Thanks @pgomulka!

docs/reference/migration/migrate_7_16.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_16.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_16.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_16.asciidoc Outdated Show resolved Hide resolved
@pgomulka pgomulka merged commit 69cf4a3 into elastic:7.x Oct 20, 2021
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 21, 2021
@pgomulka
Revert "[DOCS] [7.x] Document deprecation of storing nanosecond resol…
6e46ede 
…ution on date field (elastic#79554)"

This reverts commit 69cf4a3.
@danhermann danhermann added the >docs General docs changes label Dec 3, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Dec 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
>docs General docs changes Team:Docs Meta label for docs team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @jrodewig @danhermann