Rework predicates in TransportGetSnapshotsAction #79517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SnapshotPredicate` and `SnapshotPredicates` do almost the same thing and the way that the `SnapshotPredicates` is constructed is quite convoluted. This commit combines the two classes into one and simplifies the construction logic. Relates elastic#79341
DaveCTurner
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
Oct 20, 2021
💚 Backport successful |
DaveCTurner
added a commit
that referenced
this pull request
Oct 20, 2021
`SnapshotPredicate` and `SnapshotPredicates` do almost the same thing and the way that the `SnapshotPredicates` is constructed is quite convoluted. This commit combines the two classes into one and simplifies the construction logic. Relates #79341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SnapshotPredicateandSnapshotPredicatesdo almost the same thingand the way that the
SnapshotPredicatesis constructed is quiteconvoluted. This commit combines the two classes into one and simplifies
the construction logic.
Relates #79341