Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a unit test #79470

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Oct 19, 2021

As #79107 of the ESTestCase assertWarnings methods now check that the log level is of the expected type. This commit
puts in the correct expected log level.
Relates #79107 #78921

@masseyke masseyke added the >test-failure Triaged test failures from CI label Oct 19, 2021
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad description links? I don't see how #79305 is related, but I could be missing something.

@masseyke
Copy link
Member Author

Bad description links? I don't see how #79305 is related, but I could be missing something.

Sorry @joegallo! Too many tabs open right now! I'll fix that.

@masseyke masseyke requested a review from joegallo October 19, 2021 14:05
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it looks good to Jenkins

@masseyke masseyke merged commit 9bec026 into elastic:master Oct 19, 2021
@masseyke masseyke deleted the fix/deprecation-warning-check branch October 19, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test-failure Triaged test failures from CI v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants