EQL: Rename a test class for eclipse #79254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
Eclipse puts all of a project's classes into the same classpath. It's a silly thing but that's what it does. This was causing an error importing the EQL rest tests because we had two classes named `EqlRestIT`. I usually just closed that project after importing into eclipse. Today I decided to make Eclipse happy and rename the test.
|
Thank you, @nik9000 |
Thank you! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 18, 2021
Eclipse puts all of a project's classes into the same classpath. It's a silly thing but that's what it does. This was causing an error importing the EQL rest tests because we had two classes named `EqlRestIT`. I usually just closed that project after importing into eclipse. Today I decided to make Eclipse happy and rename the test.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 18, 2021
Eclipse puts all of a project's classes into the same classpath. It's a silly thing but that's what it does. This was causing an error importing the EQL rest tests because we had two classes named `EqlRestIT`. I usually just closed that project after importing into eclipse. Today I decided to make Eclipse happy and rename the test.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 19, 2021
* upstream/master: (34 commits) Add extensionName() to security extension (elastic#79329) More robust and consistent allowAll indicesAccessControl (elastic#79415) Fix circuit breaker leak in MultiTerms aggregation (elastic#79362) guard geoline aggregation from parents aggegator that emit empty buckets (elastic#79129) Vector tiles: increase the size of the envelope used to clip geometries (elastic#79030) Revert "[ML] Add queue_capacity setting to start deployment API (elastic#79369)" (elastic#79374) Convert token service license object to LicensedFeature (elastic#79284) [TEST] Fix ShardPathTests for MDP (elastic#79393) Fix fleet search API with no checkpints (elastic#79400) Reduce BWC version for transient settings (elastic#79396) EQL: Rename a test class for eclipse (elastic#79254) Use search_coordination threadpool in field caps (elastic#79378) Use query param instead of a system property for opting in for new cluster health response code (elastic#79351) Add new kNN search endpoint (elastic#79013) Disable BWC tests Convert auditing license object to LicensedFeature (elastic#79280) Update BWC versions after backport of elastic#78551 Enable InstantiatingObjectParser to pass context as a first argument (elastic#79206) Move xcontent filtering tests (elastic#79298) Update links to Fleet/Agent docs (elastic#79303) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eclipse puts all of a project's classes into the same classpath. It's a
silly thing but that's what it does. This was causing an error importing
the EQL rest tests because we had two classes named
EqlRestIT. Iusually just closed that project after importing into eclipse. Today I
decided to make Eclipse happy and rename the test.