-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup BWC projects for versions bigger than 7.12 #79173
Cleanup BWC projects for versions bigger than 7.12 #79173
Conversation
This should fix the failing release build. More cleanup on the ES build is required and will be done in a follow up PR
Pinging @elastic/es-delivery (Team:Delivery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM.
// We support aarch64 for linux and mac starting from 7.12 | ||
if (bwcVersion.onOrAfter("7.12.0")) { | ||
projects.addAll(asList("oss-darwin-aarch64-tar", "oss-linux-aarch64-tar", "darwin-aarch64-tar", "linux-aarch64-tar")); | ||
if (bwcVersion.onOrAfter("7.13.0")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd only ask that we include a comment explaining that this is due to oss distro removal.
This should fix the failing release build. More cleanup on the ES build is required and will be done in a follow up PR
This should fix the failing release build.
More cleanup on the ES build is required and will be done in a
follow up PR