Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup BWC projects for versions bigger than 7.12 #79173

Merged

Conversation

breskeby
Copy link
Contributor

This should fix the failing release build.
More cleanup on the ES build is required and will be done in a
follow up PR

This should fix the failing release build.
More cleanup on the ES build is required and will be done in a
follow up PR
@breskeby breskeby self-assigned this Oct 14, 2021
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.16.0 v8.0.0 labels Oct 14, 2021
@breskeby breskeby marked this pull request as ready for review October 14, 2021 17:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 14, 2021
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM.

// We support aarch64 for linux and mac starting from 7.12
if (bwcVersion.onOrAfter("7.12.0")) {
projects.addAll(asList("oss-darwin-aarch64-tar", "oss-linux-aarch64-tar", "darwin-aarch64-tar", "linux-aarch64-tar"));
if (bwcVersion.onOrAfter("7.13.0")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only ask that we include a comment explaining that this is due to oss distro removal.

@elasticsearchmachine elasticsearchmachine merged commit 4717fbb into elastic:master Oct 14, 2021
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Oct 15, 2021
This should fix the failing release build.
More cleanup on the ES build is required and will be done in a
follow up PR
breskeby added a commit that referenced this pull request Oct 15, 2021
This should fix the failing release build.
More cleanup on the ES build is required and will be done in a
follow up PR
@breskeby breskeby deleted the fix-bwc-versions-setup branch December 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants