-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Organize breaking changes by component #79162
[DOCS] Organize breaking changes by component #79162
Conversation
Pinging @elastic/es-docs (Team:Docs) |
@pugnascotia @debadair This still has some rough edges, but I'm at a stage where I'd like some feedback. I'm kinda on the fence about whether to proceed or not. Some areas I'd like feedback on:
|
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reorg looks great! I left a number of editorial suggestions based on how we're framing the deprecation messages. If I get ambitious, I'll go through the rest, but those are totally optional for getting this merged.
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/migration/migrate_8_0/_cluster-node-setting-changes.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed over the preview, the reorganized version looks much better. I don't think there's any value to my going through the diffs in detail.
* Reorganizes the 8.0.0 and 8.1.0 breaking changes and deprecations into component-based categories. * Adds an ESS icon to cluster settings on the ESS user settings allowlist. * Adds tips for sections that aren't relevant to Cloud users. * Updates the labels for some items to provide better context. Co-authored-by: debadair <[email protected]> # Conflicts: # docs/reference/migration/index.asciidoc # docs/reference/migration/migrate_8_1.asciidoc
Updates the ES breaking changes headings for elastic/elasticsearch#79162
Updates the ES breaking changes headings for elastic/elasticsearch#79162
Removes some unneeded files related to the previous organization of breaking changes. Relates to #79162 and elastic/stack-docs#1877
Removes some unneeded files related to the previous organization of breaking changes. Relates to #79162 and elastic/stack-docs#1877
Following elastic#79162, change the possible breaking / deprecation areas in the changelog schema.
PR #79162 revised the breaking changes categories in the doc. Follow this by revising the categories that changelog YAML files can use.
The structure of the breaking changes / migration guide was updated in #79162 to change the categories and split the breaking changes into different files. This PR amends the changelog generator code in line with this rework.
The structure of the breaking changes / migration guide was updated in #79162 to change the categories and split the breaking changes into different files. This PR amends the changelog generator code in line with this rework.
The change removes a node-level setting. It was accidentally placed with REST API changes as part of #79162. This moves the breaking change to the cluster and node setting changes section.
Combines several 8.0 breaking changes for the removal of API endpoints that contain mapping types. These items were separate because we previously organized breaking changes by area. This is a follow-on to #79162.
Changes
Preview
https://elasticsearch_79162.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/migrating-8.0.html
Goals
elasticsearch.yml
settings in one go.Out of scope
This PR intentionally does not:
This work should be handled as a separate effort.
I'll also need to update the Installation and Upgrade Guide so that we can remove several now-empty files. For now, I've left these files in to avoid breaking the docs build.
Testing
I took care to ensure no breaking changes were lost during the reorganization. In the HTML output, each breaking change has a
<summary>
tag. You can count these tags as a smoke test.The count should match.