Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Organize breaking changes by component #79162

Merged
merged 7 commits into from
Nov 15, 2021
Merged

[DOCS] Organize breaking changes by component #79162

merged 7 commits into from
Nov 15, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Oct 14, 2021

Changes

  • Reorganizes the 8.0 breaking changes and deprecations into component-based categories.
  • Adds an ESS icon to cluster settings on the ESS user settings allowlist.
  • Adds tips for sections that aren't relevant to Cloud users.
  • Updates the labels for some items to provide better context.

Preview

https://elasticsearch_79162.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/migrating-8.0.html

Goals

  • Make it easier for users to upgrade by grouping similar actions. For example, you can update and remove elasticsearch.yml settings in one go.
  • Make it easier for users to skip changes that aren't applicable to them.

Out of scope

This PR intentionally does not:

  • Edit or update the content of any breaking change items.
  • Combine or split any items.
  • Test any remediation steps.

This work should be handled as a separate effort.

I'll also need to update the Installation and Upgrade Guide so that we can remove several now-empty files. For now, I've left these files in to avoid breaking the docs build.

Testing

I took care to ensure no breaking changes were lost during the reorganization. In the HTML output, each breaking change has a <summary> tag. You can count these tags as a smoke test.

  1. Get a count for the currently published 8.0 breaking changes:
curl --silent https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-8.0.html | grep -c -i \<summary
  1. Get a count for the 8.0 breaking changes for this PR:
curl --silent https://elasticsearch_79162.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/migrating-8.0.html | grep -c -i \<summary

The count should match.

@jrodewig jrodewig closed this Oct 26, 2021
@jrodewig jrodewig deleted the docs__reorg-80-breaking-changes branch October 26, 2021 05:35
@jrodewig jrodewig restored the docs__reorg-80-breaking-changes branch October 26, 2021 14:19
@jrodewig jrodewig reopened this Oct 26, 2021
@jrodewig jrodewig added >docs General docs changes v8.1.0 labels Nov 4, 2021
@jrodewig jrodewig marked this pull request as ready for review November 4, 2021 22:19
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Nov 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig
Copy link
Contributor Author

jrodewig commented Nov 4, 2021

@pugnascotia @debadair This still has some rough edges, but I'm at a stage where I'd like some feedback. I'm kinda on the fence about whether to proceed or not.

Some areas I'd like feedback on:

  • Category labels and info architecture. Do these feel right? Are any too narrow or too broad?
  • Ways to improve the initial visual impact. The cluster settings and REST API sections are pretty long.
  • Wording for the Cloud tips. These also blend in with the rest of the page. Any suggestions to make them pop more is appreciated.

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reorg looks great! I left a number of editorial suggestions based on how we're framing the deprecation messages. If I get ambitious, I'll go through the rest, but those are totally optional for getting this merged.

Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed over the preview, the reorganized version looks much better. I don't think there's any value to my going through the diffs in detail.

@jrodewig jrodewig merged commit 767a237 into elastic:master Nov 15, 2021
@jrodewig jrodewig deleted the docs__reorg-80-breaking-changes branch November 15, 2021 15:42
elasticsearchmachine pushed a commit that referenced this pull request Nov 15, 2021
* Reorganizes the 8.0.0 and 8.1.0 breaking changes and deprecations into component-based categories.
* Adds an ESS icon to cluster settings on the ESS user settings allowlist.
* Adds tips for sections that aren't relevant to Cloud users.
* Updates the labels for some items to provide better context.

Co-authored-by: debadair <[email protected]>
# Conflicts:
#	docs/reference/migration/index.asciidoc
#	docs/reference/migration/migrate_8_1.asciidoc
jrodewig added a commit to elastic/stack-docs that referenced this pull request Nov 15, 2021
jrodewig added a commit to elastic/stack-docs that referenced this pull request Nov 15, 2021
jrodewig added a commit that referenced this pull request Nov 15, 2021
Removes some unneeded files related to the previous organization of breaking changes.

Relates to #79162 and elastic/stack-docs#1877
elasticsearchmachine pushed a commit that referenced this pull request Nov 15, 2021
Removes some unneeded files related to the previous organization of breaking changes.

Relates to #79162 and elastic/stack-docs#1877
pugnascotia added a commit to pugnascotia/elasticsearch that referenced this pull request Nov 16, 2021
Following elastic#79162, change the possible breaking / deprecation areas in
the changelog schema.
pugnascotia added a commit that referenced this pull request Nov 17, 2021
PR #79162 revised the breaking changes categories in the doc. Follow this by revising
the categories that changelog YAML files can use.
pugnascotia added a commit that referenced this pull request Nov 23, 2021
The structure of the breaking changes / migration guide was updated in
#79162 to change the categories and split the breaking changes into
different files. This PR amends the changelog generator code in line
with this rework.
pugnascotia added a commit that referenced this pull request Nov 23, 2021
The structure of the breaking changes / migration guide was updated in
#79162 to change the categories and split the breaking changes into
different files. This PR amends the changelog generator code in line
with this rework.
jrodewig added a commit that referenced this pull request Dec 1, 2021
The change removes a node-level setting. It was accidentally placed with REST API changes as part of #79162. This moves the breaking change to the cluster and node setting changes section.
elasticsearchmachine pushed a commit that referenced this pull request Dec 1, 2021
… (#81220)

The change removes a node-level setting. It was accidentally placed with REST API changes as part of #79162. This moves the breaking change to the cluster and node setting changes section.
jrodewig added a commit that referenced this pull request Dec 17, 2021
Combines several 8.0 breaking changes for the removal of API endpoints that contain mapping types. These items were separate because we previously organized breaking changes by area.

This is a follow-on to #79162.
elasticsearchmachine pushed a commit that referenced this pull request Dec 17, 2021
… (#81893)

Combines several 8.0 breaking changes for the removal of API endpoints that contain mapping types. These items were separate because we previously organized breaking changes by area.

This is a follow-on to #79162.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants