Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshots pending deletion in cluster state to delete snapshot once index is deleted #79156

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
9a73ba7
Add snapshots pending deletion in cluster state to delete snapshot wh…
tlrx Oct 14, 2021
579c21f
rename to SnapshotDeletionsPending
tlrx Oct 18, 2021
d15ac48
MAX_PENDING_DELETIONS_SETTING
tlrx Oct 18, 2021
7f9c32c
list
tlrx Oct 18, 2021
88c0a0b
tostring
tlrx Oct 18, 2021
9151c28
remove if is empty
tlrx Oct 18, 2021
12835bb
remove if
tlrx Oct 18, 2021
7a6ec3f
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Oct 18, 2021
7be719b
remove triggered
tlrx Oct 18, 2021
086889d
format conflicting files
tlrx Nov 9, 2021
26b255f
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Nov 9, 2021
77dfe00
nits
tlrx Nov 9, 2021
ea065e9
feedback
tlrx Nov 10, 2021
ef6ca4c
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Nov 10, 2021
91095b7
spotless
tlrx Nov 10, 2021
13a7f69
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Nov 22, 2021
916689e
skip cluster state updates
tlrx Nov 24, 2021
858d4c1
add repo clean up test
tlrx Nov 25, 2021
34de0d0
also clean ups
tlrx Nov 30, 2021
54363a1
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Nov 30, 2021
cf66c46
retries + expiration
tlrx Nov 30, 2021
5800d52
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Nov 30, 2021
e181d4a
missing uuid
tlrx Nov 30, 2021
0411ed7
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Dec 6, 2021
e83860a
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Dec 9, 2021
03efe0b
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Dec 9, 2021
a9384e2
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Jan 12, 2022
3bd59a3
5000
tlrx Jan 12, 2022
4b9080a
order of fields
tlrx Jan 12, 2022
44552c5
Optional.or()
tlrx Jan 12, 2022
bd863e9
remove //TODO
tlrx Jan 12, 2022
8bb56d3
remove curly
tlrx Jan 12, 2022
e541a4c
currents
tlrx Jan 12, 2022
2188a70
no timeout
tlrx Jan 12, 2022
69608bf
pass null
tlrx Jan 12, 2022
fce4365
test assertions
tlrx Jan 12, 2022
df1ec28
clone test
tlrx Jan 13, 2022
2d8b32a
comment
tlrx Jan 13, 2022
025952e
randomInt()
tlrx Jan 13, 2022
ad62175
randomSubsetOf()
tlrx Jan 13, 2022
350ab86
add missing setting
tlrx Jan 13, 2022
d9d711e
add SnapshotDeletionsPendingExecutor
tlrx Jan 14, 2022
2c13687
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Jan 14, 2022
39672ed
unbatched
tlrx Jan 14, 2022
db5fbd6
same error message
tlrx Jan 14, 2022
2b237b0
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Jan 17, 2022
593cf3e
fixes
tlrx Jan 17, 2022
c40f7c1
remove obsolete doc
tlrx Jan 17, 2022
dd1ced9
rename method
tlrx Jan 17, 2022
8f7baa1
Update docs/changelog/79156.yaml
tlrx Feb 2, 2022
ca3e8f5
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Mar 3, 2022
f13eaf6
batch cluster state updates that removes pending deletions
tlrx Mar 3, 2022
7fdbb90
nits
tlrx Mar 3, 2022
5dd6c23
Merge branch 'master' into delete-searchable-snapshot-with-pending-de…
tlrx Mar 14, 2022
82778ae
reset (wip)
tlrx Mar 14, 2022
fb54e4f
update branch
tlrx Mar 14, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
same error message
tlrx committed Jan 14, 2022
commit db5fbd63c9bf6a519481c223c689dc8fa2b01a73
Original file line number Diff line number Diff line change
@@ -287,7 +287,7 @@ public void testDeletePreventsClone() throws Exception {
ConcurrentSnapshotExecutionException.class,
() -> startClone(repoName, sourceSnapshot, targetSnapshot, indexName).actionGet()
);
assertThat(ex.getMessage(), containsString("cannot clone from snapshot that is being deleted"));
assertThat(ex.getMessage(), containsString("cannot clone a snapshot while a snapshot deletion is in-progress"));

unblockNode(repoName, masterName);
assertAcked(deleteFuture.get());