Put License API can return HTTP 500 #79093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License.fromXContent used to throw ElasticsearchException. ExceptionsHelper.status mapped that to HTTP 500. License.fromXContent now throws ElasticsearchParseException. ExceptionsHelper.status maps that to HTTP 400. Added LicenseIT.testPutInvalidTrialLicense to test with truncated license signature. Closes elastic#74058
justincr-elastic
requested review from
danhermann,
ywangd and
albertzaharovits
justincr-elastic
added
>bug
Team:Security
|
Pinging @elastic/es-security (Team:Security) |
justincr-elastic
added
v8.0.0
auto-backport
License.fromXContent used to throw ElasticsearchException. ExceptionsHelper.status mapped that to HTTP 500. License.fromXContent now throws ElasticsearchParseException. ExceptionsHelper.status maps that to HTTP 400. Added LicenseIT.testPutInvalidTrialLicense to test with truncated license signature. Closes elastic#74058
License.fromXContent used to throw ElasticsearchException. ExceptionsHelper.status mapped that to HTTP 500. License.fromXContent now throws ElasticsearchParseException. ExceptionsHelper.status maps that to HTTP 400. Added LicenseIT.testPutInvalidTrialLicense to test with truncated license signature. Closes elastic#74058
justincr-elastic
added
v7.15.2
:Security/License
tvernum
reviewed
Oct 15, 2021
client/rest-high-level/src/test/java/org/elasticsearch/client/LicenseIT.java
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/license/License.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
justincr-elastic
requested review from
tvernum
and removed request for
danhermann,
ywangd and
albertzaharovits
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
* Put License API can return HTTP 500 Put License now returns HTTP 400 if parsing user input fails, such as Base64 encoding or invalid signature. Closes elastic#74058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License.fromXContent used to throw ElasticsearchException.
ExceptionsHelper.status mapped that to HTTP 500.
License.fromXContent now throws ElasticsearchParseException.
ExceptionsHelper.status maps that to HTTP 400.
Added LicenseIT.testPutInvalidTrialLicense to test with
truncated license signature.
Closes #74058