CI fix - remove unsafe assertion in wildcard field #78966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leanQuery logic - can’t rely on it rewriting to a plain MatchAllDocsQuery and is sometimes wrapped in other layers
markharwood
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Oct 12, 2021
Remove unsafe assertion now that wildcard field does not simplify BooleanQuery logic - can’t rely on it rewriting to a plain MatchAllDocsQuery and is sometimes wrapped in other layers Closes elastic#78949
markharwood
added a commit
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #78520 we no longer simplify BooleanQuery logic used in the approximation query. Now we can’t rely on it rewriting to a plain MatchAllDocsQuery because it is sometimes wrapped in other layers. Removed the "instanceof" assertion