Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] EQL: Update runs syntax #78922

Merged
merged 3 commits into from
Oct 11, 2021
Merged

[DOCS] EQL: Update runs syntax #78922

merged 3 commits into from
Oct 11, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Oct 11, 2021 •
edited
Loading

@jrodewig
[DOCS] Update runs keyword syntax
d7bebd6 
Updates the EQL syntax docs for PR #78895.
@jrodewig jrodewig added :Analytics/EQL EQL querying >docs General docs changes v7.16.0 labels Oct 11, 2021
@jrodewig jrodewig marked this pull request as ready for review October 11, 2021 13:22
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team labels Oct 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@jrodewig jrodewig requested a review from costin October 11, 2021 13:24
costin
costin requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with runs=3

docs/reference/eql/syntax.asciidoc Outdated Show resolved Hide resolved
docs/reference/eql/syntax.asciidoc Outdated Show resolved Hide resolved
@jrodewig
Copy link
Contributor Author

Thanks for catching my oversight @costin. I've updated the section with the correct syntax.

@jrodewig jrodewig requested a review from costin October 11, 2021 13:58
costin
costin approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/reference/eql/syntax.asciidoc Outdated
@@ -696,16 +696,16 @@ until [ process where event.type == "stop" ]

[discrete]
[[eql-runs-keyword]]
=== `runs` keyword
=== `with runs` keywords
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keywords --> statement

@jrodewig jrodewig changed the title [DOCS] Update runs keyword syntax [DOCS] Update runs syntax Oct 11, 2021
@jrodewig jrodewig merged commit e7ab7c8 into elastic:master Oct 11, 2021
@jrodewig jrodewig deleted the docs__eql-runs-update branch October 11, 2021 14:40
@jrodewig jrodewig mentioned this pull request Oct 11, 2021
Merged
elasticsearchmachine pushed a commit that referenced this pull request Oct 11, 2021
@jrodewig
[7.x] [DOCS] Update runs syntax (#78922) (#78929)
f3500cb 
* [DOCS] Update `runs` syntax (#78922)

Updates the EQL syntax docs for PR #78895.

* Update release highlight
@jrodewig jrodewig changed the title [DOCS] Update runs syntax [DOCS] EQL: Update runs syntax Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

Assignees
No one assigned
Labels
:Analytics/EQL EQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrodewig @elasticmachine @costin @jakelandis @elasticsearchmachine