Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add deprecation warnings for SSL settings #78853

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Oct 7, 2021

#49280 added a deprecation warning when starting a node where either of the server contexts (xpack.security.transport.ssl and xpack.security.http.ssl) meet either of these conditions:

  1. The server lacks a certificate/key pair where neither ssl.keystore.path or ssl.certificate are configured
  2. The server has some ssl configuration, but ssl.enabled is not specified.

These configurations produce errors in 8.0, but generate warnings in the deprecation log for 7.x. This PR adds deprecation notices for each of these conditions and provides anchors that the deprecation API can link to.

Preview link: https://elasticsearch_78853.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/7.x/migrating-7.16.html#breaking_716_tls_changes

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content LGTM.
However, I noticed that the change is in the 7.16 migration guide, but the PR is labelled back to 7.6 - should the content be in the 7.6 migration guide instead?

@lockewritesdocs
Copy link
Contributor Author

The content LGTM. However, I noticed that the change is in the 7.16 migration guide, but the PR is labelled back to 7.6 - should the content be in the 7.6 migration guide instead?

We include the same docs in later branches, so we want them to be in the branch where the deprecated occurred, but also the following branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants