Wrap VersionPropertiesLoader in a BuildService to decouple build logic projects #78704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
breskeby
changed the title
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Oct 6, 2021
mark-vieira
approved these changes
Oct 6, 2021
| public void close() throws Exception { | ||
| } | ||
|
|
||
| public interface Params extends BuildServiceParameters { |
There was a problem hiding this comment.
Can we move this to the bottom of the class definition?
...ons/src/main/java/org/elasticsearch/gradle/internal/conventions/VersionPropertiesPlugin.java
Show resolved
Hide resolved
| .registerIfAbsent("versions", VersionPropertiesBuildService.class, spec -> { | ||
| spec.getParameters().getInfoPath().set(infoPath); | ||
| }); | ||
| project.getExtensions().add("versions", serviceProvider.forUseAtConfigurationTime().get().getProperties()); |
There was a problem hiding this comment.
I definitely like this pattern of adding the service itself as a project extension 👍
By using a BuildService we can decouple the configuration of projects but keep making expensive operations (e.g. parsing properties file or reading minimumJavaCompiler from file) only once per build. This bring us closer to decouple projects and get ultimatively configuration cache compliant. In general we will bring in more BuildServices for the main build to follow along that Pattern and ultimatevely remove usages of allprojects and subprojects in our build.
breskeby
force-pushed
the
decouple-build-tools-configuration
branch
from
6e508e4 to
1c3bbe7
Compare
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Oct 7, 2021
…c projects (elastic#78704) By using a BuildService we can decouple the configuration of projects but keep making expensive operations (e.g. parsing properties file or reading minimumJavaCompiler from file) only once per build. This bring us closer to decouple projects and get ultimatively configuration cache compliant. In general we will bring in more BuildServices for the main build to follow along that Pattern and ultimatevely remove usages of allprojects and subprojects in our build.
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Oct 9, 2021
* master: Fix DataTierTests package and add a validation test (elastic#78880) Fix split package org.elasticsearch.common.xcontent (elastic#78831) Store DataTier Preference directly on IndexMetadata (elastic#78668) [DOCS] Fixes typo in calendar API example (elastic#78867) Improve Node Shutdown Observability (elastic#78727) Convert encrypted snapshot license object to LicensedFeature (elastic#78731) Revert "Make nodePaths() singular (elastic#72514)" (elastic#78801) Fix incorrect generic type in PolicyStepsRegistry (elastic#78628) [DOCS] Fixes ML get calendars API (elastic#78808) Implement GET API for System Feature Upgrades (elastic#78642) [TEST] More MetadataStateFormat tests (elastic#78577) Add support for rest compatibility headers to the HLRC (elastic#78490) Un-ignoring tests after backporting fix (elastic#78830) Add node REPLACE shutdown implementation (elastic#76247) Wrap VersionPropertiesLoader in a BuildService to decouple build logic projects (elastic#78704) Adjust /_cat/templates not to request all metadata (elastic#78829) [DOCS] Fixes ML get scheduled events API (elastic#78809) Enable exit on out of memory error (elastic#71542) # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a BuildService we can decouple the configuration of projects but keep making
expensive operations (e.g. parsing properties file or reading minimumJavaCompiler from file) only once
per build.
This bring us closer to decouple projects and get ultimatively configuration cache compliant. In
general we will bring in more BuildServices for the main build to follow along that Pattern and
ultimatevely remove usages of allprojects and subprojects in our build.