Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky queue resizing tests #78634

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Oct 4, 2021

The min and max queue resizing tests sometimes fail due to timing
issues. Since the queue resizing is already removed for 8.0 (#52280),
there is less incentive to debug the flakiness. Given there are some
other tests of queue resizing, and the feature is already removed in
upcoming versions of ES, this commit removes the flaky tests.

closes #71476

The min and max queue resizing tests sometimes fail due to timing
issues. Since the queue resizing is already removed for 8.0 (elastic#52280),
there is less incentive to debug the flakiness. Given there are some
other tests of queue resizing, and the feature is already removed in
upcoming versions of ES, this commit removes the flaky tests.

closes elastic#71476
@rjernst rjernst added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label v7.16.0 labels Oct 4, 2021
@rjernst rjernst requested a review from dakrone October 4, 2021 18:23
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked and we do have other tests for incrementing and decrementing the queue_size for this (test*Up and test*Down)

@rjernst rjernst added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 4, 2021
@elasticsearchmachine elasticsearchmachine merged commit 9c4b41e into elastic:7.x Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants