Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Document empty first line support for msearch API #78284

Merged
merged 5 commits into from
Sep 27, 2021
Merged

[DOCS] Document empty first line support for msearch API #78284

merged 5 commits into from
Sep 27, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 23, 2021 •
edited
Loading

@jrodewig jrodewig added :Search/Search Search-related issues that do not fall into other categories >docs General docs changes labels Sep 23, 2021
@jrodewig jrodewig marked this pull request as ready for review September 23, 2021 23:02
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Sep 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 24, 2021 •
edited
Loading

I originally included some example snippets, but it looks like we strip out leading whitespace. I couldn't figure out a good workaround. Let me know if this text is enough without a visual aid.

cbuescher
cbuescher approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think the text is clear enough.

@jrodewig
Copy link
Contributor Author

Thanks @cbuescher.

@jrodewig jrodewig merged commit b20939f into elastic:master Sep 27, 2021
@jrodewig jrodewig deleted the docs__msearch-empty-first-line branch September 27, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

@javanna javanna Awaiting requested review from javanna

Assignees
No one assigned
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrodewig @elasticmachine @cbuescher @jakelandis @elasticsearchmachine