Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add time_series_dimension and time_series_metric mapping parameters #78265

Merged
merged 9 commits into from
Sep 27, 2021

Conversation

csoulios
Copy link
Contributor

@csoulios csoulios commented Sep 23, 2021

csoulios and others added 3 commits September 23, 2021 18:15
Added the dimension parameter to the following field types:

    keyword
    ip
    Numeric field types (integer, long, byte, short)

The dimension parameter is of type boolean (default: false) and is used
to mark that a field is a time series dimension field.

Relates to elastic#74014
This PR adds the following constraints to dimension fields:

    It must be an indexed field and must has doc values
    It cannot be multi-valued
    The number of dimension fields in the index mapping must not be more than 16. This should be configurable through an index property (index.mapping.dimension_fields.limit)
    keyword fields cannot be more than 1024 bytes long
    keyword fields must not use a normalizer

Based on the code added in PR elastic#74450
Relates to elastic#74660
Adds a test for setting the maximum number of dimensions setting and
tests the names and types of the metadata fields in the index.
Previously we just asserted the count of metadata fields. That made it
hard to read failures.
@csoulios csoulios marked this pull request as draft September 23, 2021 15:59
csoulios and others added 5 commits September 23, 2021 19:03
Test was failing because it was testing 1024 bytes long keyword and assertion was failing.

Closes elastic#75225
This PR adds the time_series_metric parameter to the following field types:

    Numeric field types
    histogram
    aggregate_metric_double
…tic#78012)

This PR renames dimension mapping parameter to time_series_dimension to make it consistent with time_series_metric parameter (elastic#76766)

Relates to elastic#74450 and elastic#74014
…#78204)

    Added the time_series_metric mapping parameter to the unsigned_long and scaled_float field types
    Added the time_series_dimension mapping parameter to the unsigned_long field type

Fixes elastic#78100

Relates to elastic#76766, elastic#74450 and elastic#74014
@csoulios csoulios marked this pull request as ready for review September 23, 2021 17:55
@csoulios csoulios requested a review from nik9000 September 23, 2021 17:55
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csoulios csoulios merged commit 6cccbf5 into elastic:7.x Sep 27, 2021
@csoulios csoulios deleted the backport-ts-params-7.x branch September 27, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants