Script: compile/cache eviction history metric placeholders #78257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 5m/15m/24h metrics to _nodes/stats when those metrics are non-zero. Those metrics are not yet populated. BWC: history metrics are only sent between v8.0.0+ nodes, v7.16.0 nodes will not send those metrics until they are populated. Refs: elastic#62899
stu-elastic
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Sep 23, 2021
server/src/main/java/org/elasticsearch/script/ScriptContextStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/ScriptContextStats.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/action/admin/cluster/node/stats/NodeStatsTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/ScriptContextStats.java
Outdated
Show resolved
Hide resolved
jdconrad
approved these changes
Sep 23, 2021
server/src/main/java/org/elasticsearch/script/ScriptContextStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/ScriptContextStats.java
Outdated
Show resolved
Hide resolved
rjernst
approved these changes
Sep 23, 2021
| @@ -555,11 +558,26 @@ public static NodeStats createNodeStats() { | |||
| List<ScriptContextStats> stats = new ArrayList<>(numContents); | |||
| HashSet<String> contexts = new HashSet<>(); | |||
| for (int i = 0; i < numContents; i++) { | |||
| List<ScriptContextStats.TimeSeries> timeSeries = new ArrayList<>(); | |||
There was a problem hiding this comment.
I think this would be more readable if it was moved to a helper function, eg randomTimeSeries(), then it can be used below inline, without needing this weirdness with a length 2 list.
💔 Backport failed
You can use sqren/backport to manually backport by running |
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Sep 27, 2021
…8257) Adds 5m/15m/24h metrics to _nodes/stats when those metrics are non-zero. Those metrics are not yet populated. BWC: history metrics are only sent between v8.0.0+ nodes, v7.16.0 nodes will not send those metrics until they are populated. Refs: elastic#62899 Backport: db75c4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 5m/15m/24h metrics to _nodes/stats when those metrics
are non-zero. Those metrics are not yet populated.
BWC: history metrics are only sent between v8.0.0+ nodes,
v7.16.0 nodes will not send those metrics until they are populated.
Refs: #62899