Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add composite runtime fields #78050

Merged

Conversation

lockewritesdocs
Copy link
Contributor

Adds documentation for composite runtime fields that were added in #76287.

@lockewritesdocs lockewritesdocs added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.15.0 v7.16.0 labels Sep 21, 2021
@lockewritesdocs lockewritesdocs self-assigned this Sep 21, 2021
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Docs Meta label for docs team labels Sep 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lockewritesdocs

Is it worth adding composite to the list of supported runtime field types at line 152 as well? Maybe with a link to this section? We should also add a note to the index-time script section saying that composite fields are not supported (yet!)

@lockewritesdocs
Copy link
Contributor Author

Thanks Alan! I added composite to the list of supported data types in d863483, and added a note that you cannot currently index a composite runtime field in 6ae2b31. If you're 👍 to those changes, I'll merge and backport appropriately.

@joegallo joegallo removed the v7.15.0 label Sep 22, 2021
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lockewritesdocs!

@lockewritesdocs lockewritesdocs merged commit 7d61b02 into elastic:master Sep 22, 2021
@lockewritesdocs lockewritesdocs deleted the docs__composite-runtime-fields branch September 22, 2021 11:56
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Sep 22, 2021
* [DOCS] Add composite runtime fields

* Update snippets and tests

* Add note that composite runtime fields cannot be indexed yet
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
lockewritesdocs pushed a commit that referenced this pull request Sep 22, 2021
* [DOCS] Add composite runtime fields

* Update snippets and tests

* Add note that composite runtime fields cannot be indexed yet
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
lockewritesdocs pushed a commit that referenced this pull request Sep 22, 2021
* [DOCS] Add composite runtime fields

* Update snippets and tests

* Add note that composite runtime fields cannot be indexed yet
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
javanna added a commit to javanna/elasticsearch that referenced this pull request Mar 30, 2022
The painless execute API supports the composite_field context since the composite field was added.
This commit adds docs for it where missing.

Relates to elastic#78050
javanna added a commit that referenced this pull request Apr 19, 2022
The painless execute API supports the composite_field context since the composite field was added.
This commit adds docs for it where missing.

Relates to #78050
javanna added a commit to javanna/elasticsearch that referenced this pull request Apr 19, 2022
…tic#85513)

The painless execute API supports the composite_field context since the composite field was added.
This commit adds docs for it where missing.

Relates to elastic#78050
javanna added a commit that referenced this pull request Apr 19, 2022
…) (#86000)

The painless execute API supports the composite_field context since the composite field was added.
This commit adds docs for it where missing.

Relates to #78050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.15.0 v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants