-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Document time_series_metric
mapping parameter
#78013
Conversation
Documents the `time_series_metric` mapping parameter added with PR #76766.
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Pinging @elastic/es-search (Team:Search) |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment for numeric fields.
Also, in PR #78012 I renamed dimension
parameter to time_series_parameter
. Not sure if you want to add this change in the same or a separate PR.
For numeric fields, this parameter accepts `gauge` and `counter`. You can't | ||
update this parameter for existing fields. | ||
+ | ||
`scaled_float` and `unsigned_long` fields don't support this parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure where the constraint that scaled_float
and unsigned_long
fields don't support this parameter comes from. There is no such constraint in the code. Am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During my testing, I wasn't able to create a scaled_float
or unsigned_long
field with the parameter. I assumed that was intended, but it may be a bug.
I opened #78100 for the bug report. I'll remove this sentence from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening the issue. I will check that asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I left some more comments.
One last thing we should add is that a numeric field cannot be both a dimension and a metric. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for iterating so fast on this!
Documents the
time_series_metric
mapping parameter added with PR #76766.Also renames the
dimension
parameter totime_series_dimension
for PR #78012.Previews
aggregate_metric_double
: https://elasticsearch_78013.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/aggregate-metric-double.html#aggregate-metric-double-paramshistogram
: https://elasticsearch_78013.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/histogram.html#histogram-paramsNumeric field types: https://elasticsearch_78013.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/number.html#number-params
ip
: https://elasticsearch_78013.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/ip.html#ip-paramskeyword
: https://elasticsearch_78013.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/keyword.html#keyword-paramsIndex settings: https://elasticsearch_78013.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/index-modules.html#index-mapping-dimension-fields-limit