Deprecate ignore_throttled parameter #77864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backporting elastic#77479 to 7.x branch. Frozen indices are deprecated, which will make ignore_throttled obsolete. Some changes to HLRC HLRC and related tests were required in order to deprecate ignore_throttled parameter: * Change HLRC request classes to set indices options initial value to null. This avoids sending the ignore_throttled parameter (and other indices options parameters) and therefore avoids the depracation warning header in the response. All these request classes had the indices options set to what is the defaukt in the corresponding action request class. So sending these indices options params was a noop, which is the same as not sending indices options parameters, which is what this change does. * For transport action request classes that are reused in the HLRC as request class, change the corresponding hlrc request converter to only send indices options params if the indices options are different than what the default is. * For tests that use a non default indices options, allow 'ignore_throttled is deprecated' warning. Other changes: * A number of tests have been changed to allowed warning header for deprecated ignore_throttled parameter. * Some rest v7 compat yaml tests are temporary muted, but will be unmuted once this change has been backported. Relates to elastic#70192
martijnvg
added
the
auto-merge-without-approval
5 tasks
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Aug 23, 2022
…s options (elastic#89469) This adds a note about an unintended break in behavior for the HLRC with regard to the indices options that are sent by default with requests. Relates to elastic#77864
|
Why I use 7.17.6 java client with elastic8.5 stil have "[ignore_throttled] parameter is deprecated"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #77479 to 7.x branch.
Frozen indices are deprecated, which will make ignore_throttled obsolete.
Some changes to HLRC HLRC and related tests were required in order to deprecate ignore_throttled parameter:
This avoids sending the ignore_throttled parameter (and other indices options parameters)
and therefore avoids the depracation warning header in the response. All these
request classes had the indices options set to what is the defaukt in the corresponding
action request class. So sending these indices options params was a noop, which is the same
as not sending indices options parameters, which is what this change does.
change the corresponding hlrc request converter to only send indices options params
if the indices options are different than what the default is.
warning.
Other changes:
change has been backported.
Relates to #70192