Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Improve HotThreadsRequest BWC test #77818

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[TEST] Improve HotThreadsRequest BWC test #77818

merged 1 commit into from
Sep 15, 2021

Conversation

grcevski
Copy link
Contributor

This PR is addressing the test improvement comment for #77462.
Instead of the manual serialization, the test is now using VersionUtils
to serialize and deserialize the same request using different versions.

[TEST] Improve HotThreadsRequest BWC test
b0bd4b4 
This commit is addressing the test improvement comment for elastic#77462.
Instead of the manual serialization, the test is now using VersionUtils
to serialize and deserialize the same request using different versions.
@grcevski grcevski added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label v8.0.0 Team:Core/Infra Meta label for core/infra team auto-backport Automatically create backport pull requests when merged v7.16.0 labels Sep 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

rjernst
rjernst approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grcevski
Copy link
Contributor Author

Thanks @rjernst!

@grcevski grcevski merged commit 008235e into elastic:master Sep 15, 2021
@grcevski grcevski deleted the tests/better_hotthreads_bwc_test branch September 15, 2021 20:08
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 77818

grcevski added a commit to grcevski/elasticsearch that referenced this pull request Sep 16, 2021
@grcevski
[TEST] Improve HotThreadsRequest BWC test (elastic#77818)
a6c2bc7 
This change is addressing the test improvement comment for elastic#77462.
Instead of the manual serialization, the test is now using VersionUtils
to serialize and deserialize the same request using different versions.
@grcevski grcevski mentioned this pull request Sep 16, 2021
Merged
grcevski added a commit that referenced this pull request Sep 16, 2021
@grcevski
[TEST] Improve HotThreadsRequest BWC test (#77818) (#77886)
09fca4e 
Backport of #77818

This change is addressing the test improvement comment for #77462.
Instead of the manual serialization, the test is now using VersionUtils
to serialize and deserialize the same request using different versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grcevski @elasticmachine @elasticsearchmachine @rjernst @jakelandis