Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Hardcode java11 for Pull Request FIPS CI #77736

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[Test] Hardcode java11 for Pull Request FIPS CI #77736

merged 1 commit into from
Sep 16, 2021

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Sep 15, 2021

This PR changes the Pull Request FIPS CI to use Java 11 instead of Java
8 for consistency with Periodic FIPS CI setup and the support matrix.

Supercedes: #77671

@ywangd
[Test] Hardcode java11 for Pull Request FIPS CI
392f701 
This PR changes the Pull Request FIPS CI to use Java 11 instead of Java
8 for consistency with Periodic FIPS CI setup and the support matrix.
@ywangd ywangd added >test Issues or PRs that are addressing/adding tests v8.0.0 :Security/FIPS Running ES in FIPS 140-2 mode v7.16.0 labels Sep 15, 2021
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Sep 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@ywangd ywangd mentioned this pull request Sep 15, 2021
Closed
@ywangd
Copy link
Member Author

ywangd commented Sep 15, 2021

Somehow the fips CI jobs didn't run for this PR. I cannot find anything in jenkins either. Did my change break something? Not sure where to look at.

@mark-vieira
Copy link
Contributor

@elasticmachine run elasticsearch-ci/part-1-fips

@mark-vieira
Copy link
Contributor

mark-vieira commented Sep 15, 2021 •
edited
Loading

@elasticmachine run elasticsearch-ci/part-2-fips

1 similar comment
@mark-vieira
Copy link
Contributor

@elasticmachine run elasticsearch-ci/part-2-fips

@mark-vieira
Copy link
Contributor

Somehow the fips CI jobs didn't run for this PR. I cannot find anything in jenkins either. Did my change break something? Not sure where to look at.

Strange, I was able to manually trigger them. Perhaps because the Team:Security label was added later by our bot they weren't initially triggered?

mark-vieira
mark-vieira approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ywangd ywangd merged commit 8e216b3 into elastic:master Sep 16, 2021
@ywangd
Copy link
Member Author

ywangd commented Sep 16, 2021

This PR is labelled with v7.16.0 because the change affects 7.x as well. But backport is not needed because 7.x branch also uses the same PR CI job definition files from the master branch.

ywangd added a commit to ywangd/elasticsearch that referenced this pull request Sep 16, 2021
@ywangd
Remove test support for FIPS with JDK 8
dd10b8e 
We now explicilty require JDK 11 and BC-FIPS for FIPS 140-2 mode. Both
periodic and PR CI jobs have been updated to only test for JDK 11 and
the latest JDK. As a result, the support for testing with JDK 8 is no
longer needed and this PR removes it.

Relates: elastic#77736
@ywangd ywangd mentioned this pull request Sep 16, 2021
Merged
@mark-vieira
Copy link
Contributor

This PR is labelled with v7.16.0 because the change affects 7.x as well. But backport is not needed because 7.x branch also uses the same PR CI job definition files from the master branch.

Thanks. Since this is labeled >test isn't not included in release notes anyway so it's fine either way.

ywangd added a commit that referenced this pull request Oct 18, 2021
@ywangd
Remove test support for FIPS with JDK 8 (#77847)
25b1020 
We now explicilty require JDK 11 and BC-FIPS for FIPS 140-2 mode. Both
periodic and PR CI jobs have been updated to only test for JDK 11 and
the latest JDK. As a result, the support for testing with JDK 8 is no
longer needed and this PR removes it.

Relates: #77736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

@tvernum tvernum Awaiting requested review from tvernum

Assignees
No one assigned
Labels
:Security/FIPS Running ES in FIPS 140-2 mode Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywangd @elasticmachine @mark-vieira @jakelandis