Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add deprecation docs for incompatible builds #77730

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[DOCS] Add deprecation docs for incompatible builds #77730

merged 1 commit into from
Sep 16, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 14, 2021

We deprecated the es.unsafely_permit_handshake_from_incompatible_builds system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.

Preview

https://elasticsearch_77730.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/7.x/migrating-7.11.html#deprecate-unsafely_permit_handshake_from_incompatible_builds

@jrodewig
Copy link
Contributor Author

@elasticmachine test this please

…compatible_builds`

We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
@jrodewig jrodewig marked this pull request as ready for review September 14, 2021 22:22
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Sep 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig added the :Distributed Coordination/Network Http and internode communication implementations label Sep 14, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Sep 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2 although IMO it'd also be fine not to document this, we deliberately didn't document the setting in the first place, we just added it in case we had an emergency need to bypass those checks but we've never had such a need.

@jrodewig
Copy link
Contributor Author

Thanks @DaveCTurner @masseyke!

IMO it'd also be fine not to document this, we deliberately didn't document the setting in the first place, we just added it in case we had an emergency need to bypass those checks but we've never had such a need.

I'll go ahead and merge/publish this since we have a corresponding breaking change in the 8.0 docs:
https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_transport_changes

Probably out of scope for this PR, but we should consider the criteria for not documenting a breaking change. We have quite a few for 8.0. It'd be great for users to have to parse through fewer of them.

@jrodewig jrodewig merged commit 8402d6d into elastic:7.x Sep 16, 2021
@jrodewig jrodewig deleted the docs__deprecate-permit-handshake branch September 16, 2021 21:25
jrodewig added a commit that referenced this pull request Sep 16, 2021
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.11.3 v7.12.2 v7.13.5 v7.14.3 v7.15.1 v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants