Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce external build-tools JavaRestTestPlugin #77603

Merged

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Sep 11, 2021

Introduce an external variant of the java rest test plugin in build-tools for external plugin authors to use. We also rename the existing plugin to internal.

Closes #77543

@mark-vieira mark-vieira marked this pull request as ready for review September 13, 2021 16:38
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Sep 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira
Copy link
Contributor Author

I've ripped out the example plugins refactoring for now given we want to do a BC for 7.14.2 and 7.15 this week we should limit the scope of this PR.

@mark-vieira
Copy link
Contributor Author

@elasticmachine update branch

@mark-vieira mark-vieira added auto-backport-and-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Sep 13, 2021
@elasticsearchmachine elasticsearchmachine merged commit 2393eaf into elastic:master Sep 13, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts
7.15 Commit could not be cherrypicked due to conflicts
7.14 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 77603

@dweiss
Copy link
Contributor

dweiss commented Sep 13, 2021

Thank you, @mark-vieira

mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Sep 13, 2021
* Add external build tools JavaRestTestPlugin

* Fix integration test

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	build-tools/src/main/java/org/elasticsearch/gradle/util/GradleUtils.java
#	client/rest-high-level/qa/ssl-enabled/build.gradle
#	modules/lang-mustache/build.gradle
#	modules/reindex/build.gradle
#	modules/transport-netty4/build.gradle
@mark-vieira mark-vieira deleted the java_rest_test_plugin branch September 13, 2021 20:17
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Sep 13, 2021
* Add external build tools JavaRestTestPlugin

* Fix integration test

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	build-tools/src/main/java/org/elasticsearch/gradle/util/GradleUtils.java
#	client/rest-high-level/qa/ssl-enabled/build.gradle
#	modules/lang-mustache/build.gradle
#	modules/reindex/build.gradle
#	modules/transport-netty4/build.gradle
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Sep 13, 2021
* Add external build tools JavaRestTestPlugin

* Fix integration test

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	build-tools/src/main/java/org/elasticsearch/gradle/util/GradleUtils.java
#	client/rest-high-level/qa/ssl-enabled/build.gradle
#	modules/lang-mustache/build.gradle
#	modules/reindex/build.gradle
#	modules/transport-netty4/build.gradle
#	test/external-modules/die-with-dignity/build.gradle
#	x-pack/plugin/vector-tile/build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.14.2 v7.15.1 v7.16.0 v8.0.0-beta1
Projects
None yet
6 participants