Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify indexing a runtime field #77117

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Sep 1, 2021

Borrows some language from the Compromises section for runtime fields to expand the explanation around indexing a runtime field.

Preview link: https://elasticsearch_77117.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/runtime-indexed.html

Closes #77102

@lockewritesdocs lockewritesdocs added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 auto-backport Automatically create backport pull requests when merged v7.15.0 v7.16.0 v7.14.2 labels Sep 1, 2021
@lockewritesdocs lockewritesdocs self-assigned this Sep 1, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Sep 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround @lockewritesdocs! Lgtm, but I'd be more at ease if more knowledgeable colleagues like @javanna or @romseygeek would have a quick look too.

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd say 'uses these indexed fields to drive queries', rather than saying it uses them first; but other than that, LGTM.

@lockewritesdocs lockewritesdocs merged commit 32e364d into elastic:master Sep 1, 2021
@lockewritesdocs lockewritesdocs deleted the docs__runtime-fields-indexing branch September 1, 2021 15:59
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.15 Commit could not be cherrypicked due to conflicts
7.x Commit could not be cherrypicked due to conflicts
7.14 Commit could not be cherrypicked due to conflicts

To backport manually run backport --upstream elastic/elasticsearch --pr 77117

lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Sep 1, 2021
* [DOCS] Clarify indexing a runtime field

* Clarify wording based on reviewer feedback
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Sep 1, 2021
* [DOCS] Clarify indexing a runtime field

* Clarify wording based on reviewer feedback
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
lockewritesdocs pushed a commit that referenced this pull request Sep 1, 2021
* [DOCS] Clarify indexing a runtime field

* Clarify wording based on reviewer feedback
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
lockewritesdocs pushed a commit that referenced this pull request Sep 1, 2021
* [DOCS] Clarify indexing a runtime field

* Clarify wording based on reviewer feedback
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
lockewritesdocs pushed a commit that referenced this pull request Sep 1, 2021
* [DOCS] Clarify indexing a runtime field

* Clarify wording based on reviewer feedback
# Conflicts:
#	docs/reference/mapping/runtime.asciidoc
@jakelandis jakelandis removed the v8.0.0 label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.14.2 v7.15.0 v7.16.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance of runtime field in mapping
6 participants