Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds information about version compatibility headers #77096

Merged
merged 5 commits into from
Sep 3, 2021

Conversation

debadair
Copy link
Contributor

@debadair debadair commented Sep 1, 2021

Updates the API conventions to include information about the version compatibility headers.

Provides a place for the Upgrade Assistant to link to: elastic/kibana#110469

@debadair debadair added >docs General docs changes :Core/Infra/REST API REST infrastructure and utilities v8.0.0 v7.14.0 v7.15.0 v7.16.0 labels Sep 1, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Core/Infra Meta label for core/infra team labels Sep 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

update applications before upgrading {es},
having to coordinate the necessary changes can be an impediment to upgrading.

To enable an application to continue to function without modification after an upgrade,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be more clear the functionality (semantics) are not necessarily maintained, the compatibility is with the syntax of rest request/response.

Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-blocking suggestions if you're keen on using them. LGTM otherwise 👍

docs/reference/api-conventions.asciidoc Outdated Show resolved Hide resolved
docs/reference/api-conventions.asciidoc Outdated Show resolved Hide resolved
that impact how you interact with {es}.
While we recommend that you monitor the deprecation log and
update applications before upgrading {es},
having to coordinate the necessary changes can be an impediment to upgrading.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
having to coordinate the necessary changes can be an impediment to upgrading.
implementing the necessary changes can be an impediment to upgrading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"having to coordinate" feels imprecise, thought that might be the intention given that we're talking about all the things that need to happen for an upgrade.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was deliberate. Using the compatibility headers enables you to decouple the implementation and deployment of app updates from the upgrade process.

@debadair debadair merged commit 5b41c03 into elastic:master Sep 3, 2021
debadair added a commit to debadair/elasticsearch that referenced this pull request Sep 3, 2021
…77096)

* [DOCS] Adds information about version compatibility

* Clarified that the behavior is not guaranteed to be the same

* Update docs/reference/api-conventions.asciidoc

* Update docs/reference/api-conventions.asciidoc

* Update docs/reference/api-conventions.asciidoc

Co-authored-by: Adam Locke <[email protected]>

Co-authored-by: Adam Locke <[email protected]>
debadair added a commit that referenced this pull request Sep 3, 2021
…77279)

* [DOCS] Adds information about version compatibility

* Clarified that the behavior is not guaranteed to be the same

* Update docs/reference/api-conventions.asciidoc

* Update docs/reference/api-conventions.asciidoc

* Update docs/reference/api-conventions.asciidoc

Co-authored-by: Adam Locke <[email protected]>

Co-authored-by: Adam Locke <[email protected]>

Co-authored-by: Adam Locke <[email protected]>
wjp719 added a commit to wjp719/elasticsearch that referenced this pull request Sep 4, 2021
* master: (128 commits)
  Mute DieWithDignityIT (elastic#77283)
  Fix randomization in MlNodeShutdownIT (elastic#77281)
  Add target_node_name for REPLACE shutdown type (elastic#77151)
  [DOCS] Adds information about version compatibility headers (elastic#77096)
  Fix template equals when mappings are wrapped (elastic#77008)
  Fix TextFieldMapper Retaining a Reference to its Builder (elastic#77251)
  Move die with dignity to be a test module (elastic#77136)
  Update task names for rest compatiblity (elastic#75267)
  [ML] adjusting bwc serialization for elastic#77256 (elastic#77257)
  Move `index.hidden` from Static to Dynamic settings (elastic#77218)
  Handle cgroups v2 in `OsProbe` (elastic#77128)
  Choose postings format from FieldMapper instead of MappedFieldType (elastic#77234)
  Add segment sorter for data streams (elastic#75195)
  Update skip after backport (elastic#77212)
  [ML] adding new defer_definition_decompression parameter to put trained model API (elastic#77189)
  [ML] Fix bug in inference stats persister for when feature reset is called
  Only check replicas in cancelling existing recoveries. (elastic#60564)
  Format `AbstractFilteringTestCase` (elastic#77217)
  [DOCS] Fixes line breaks. (elastic#77248)
  Convert 'routing' values in REST API tests to strings
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.14.0 v7.15.0 v7.16.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants