Fix alias resolution in match query with synonyms #76688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>regression
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
nik9000
approved these changes
Aug 23, 2021
|
Thanks @nik9000 ! |
jtibshirani
added a commit
that referenced
this pull request
Aug 23, 2021
When backporting #68795, we introduced a regression around `match` queries on field aliases. If the `match` query parses to a `synonym` query (because its analyzer can produce multiple tokens at a single position), then we don't resolve the field alias to its concrete field. This means the query will not have any results. We already had a test for this case but it was too narrow. Note this regression only affects 7.x, there is no bug on master.
jtibshirani
added a commit
that referenced
this pull request
Aug 23, 2021
When backporting #68795, we introduced a regression around `match` queries on field aliases. If the `match` query parses to a `synonym` query (because its analyzer can produce multiple tokens at a single position), then we don't resolve the field alias to its concrete field. This means the query will not have any results. We already had a test for this case but it was too narrow. Note this regression only affects 7.x, there is no bug on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When backporting #68795, we introduced a regression around
matchqueries onfield aliases. If the
matchquery parses to asynonymquery (because itsanalyzer can produce multiple tokens at a single position), then we don't
resolve the field alias to its concrete field. This means the query will not
have any results.
We already had a test for this case but it was too narrow. Note this regression
only affects 7.x, there is no bug on master.