-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] More robust assertions for sorting and pagination #76654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove potential duplicates from results gathered with sorting and search_after. Pagination does not use _doc anymore since it could change between requests. Resolves: elastic#76542
ywangd
added
>test
Issues or PRs that are addressing/adding tests
:Security/Security
Security issues without another label
v8.0.0
v7.15.0
labels
Aug 18, 2021
Pinging @elastic/es-security (Team:Security) |
tvernum
approved these changes
Aug 24, 2021
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Aug 24, 2021
* master: (21 commits) [Test] More robust assertions for sorting and pagination (elastic#76654) [Test] Fix filename check on Windows (elastic#76807) Upgrade build scan plugin to 3.6.4 (elastic#76784) Remove keystore initial_md5sum (elastic#76835) Don't export docker images on assemble (elastic#76817) Fix testMasterStatsOnSuccessfulUpdate (elastic#76844) AwaitsFix for elastic#76840 Make Releasing Aggregation Buffers Safer (elastic#76741) Re-enable BWC tests after backport of elastic#76771 (elastic#76839) Dispatch large bulk requests to write thread (elastic#76736) Disable BWC tests for elastic#76771 Pull down beats artifacts when performing release tests Add timing stats to publication process (elastic#76771) Fix BanFailureLoggingTests some more (elastic#76668) Mention "warn threshold" in master service slowlog (elastic#76815) Fix DockerTests.test010Install Re-enable tests affected by elastic#75097 (elastic#76814) Fix testRecoveryIsCancelledAfterDeletingTheIndex (elastic#76644) Test fix -WildcardFieldMapperTests bad test data. (elastic#76819) Updating supported version after backporting the feature (elastic#76794) ... # Conflicts: # server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Aug 24, 2021
Remove potential duplicates from results gathered with sorting and search_after. Pagination does not use _doc anymore since it could change between requests. Resolves: elastic#76542
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Aug 24, 2021
Remove potential duplicates from results gathered with sorting and search_after. Pagination does not use _doc anymore since it could change between requests. Resolves: elastic#76542
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 24, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Security/Security
Security issues without another label
Team:Security
Meta label for security team
>test
Issues or PRs that are addressing/adding tests
v7.16.0
v8.0.0-alpha2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagination does not use _doc anymore since it could change between requests
for things like segment merging, hitting on a different replica.
Resolves: #76542