Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute recover from snapshot rolling first round #76601

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Mute recover from snapshot rolling first round #76601

merged 1 commit into from
Aug 17, 2021

Conversation

henningandersen
Copy link
Contributor

Selectively muting parts of the rolling upgrade test for recover from
snapshot.

Relates #76595

@henningandersen
Mute recover from snapshot rolling first round
05ed2da 
Selectively muting parts of the rolling upgrade test for recover from
snapshot.

Relates elastic#76595
@henningandersen henningandersen added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v7.15.0 labels Aug 17, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@henningandersen henningandersen mentioned this pull request Aug 17, 2021
Closed
@henningandersen
Copy link
Contributor Author

Jenkins misbehaving so retrying:

@elasticmachine run elasticsearch-ci/part-1
@elasticmachine run elasticsearch-ci/part-2

@henningandersen
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample
@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample

DaveCTurner
DaveCTurner approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick fix.

I suspect the problem is caused by a rebalance moving the primary onto the newly-upgraded node, but I haven't seen a failure in captivity to confirm that yet. If so I think we could do something a bit stronger here, e.g. apply an allocation filter to exclude the solitary upgraded node, then explicitly cancel any shards it holds to promote a replica on the old nodes, and then remove replicas.

Anyway LGTM as a quick fix.

@henningandersen henningandersen merged commit 2bfeab6 into elastic:master Aug 17, 2021
henningandersen added a commit that referenced this pull request Aug 17, 2021
@henningandersen
Mute recover from snapshot rolling first round (#76601)
bc278d6 
Selectively muting parts of the rolling upgrade test for recover from
snapshot.

Relates #76595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.15.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henningandersen @elasticmachine @DaveCTurner @jakelandis