Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Serialization of SnapshotsInProgress in 7.x #76553

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

original-brownbear
Copy link
Member

We must not send the by-repo-shard-id map for normal
snapshots. The conditional got lost in 7.x and 7.14
because of a merge error. This aligns master and 7.x behavior.

closes #76552

non-issue as this bug hasn't been released yet

We must not send the by-repo-shard-id map for normal
snapshots. The conditional got lost in `7.x` and `7.14`
because of a merge error. This aligns master and 7.x behavior.

closes elastic#76552
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (provided CI passes).

@original-brownbear
Copy link
Member Author

Ah damn I have to merge this to 7.14 first, otherwise we keep breaking in 7.14.

@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/bwc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.14.1 v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants