[Test] Improve test assert for better message on failure #76543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
|
@elasticmachine update branch |
tvernum
approved these changes
Aug 17, 2021
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Aug 17, 2021
This PR adjusts assertions in testPagination so that more detailed messages would be made available on failures. For example, if the sorted keys do not match the expected order, it now shows all keys for better context instead of just the single mismatched key. Relates: elastic#76542
ywangd
added a commit
that referenced
this pull request
Aug 17, 2021
…6596) * [Test] Improve assertions for better messages on failure (#76543) This PR adjusts assertions in testPagination so that more detailed messages would be made available on failures. For example, if the sorted keys do not match the expected order, it now shows all keys for better context instead of just the single mismatched key. Relates: #76542 * fix for 7.x quirks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts assertions in
testPaginationso that more detailed messages would be made available on failures. For example, if the sorted keys do not match the expected order, it now shows all keys for better context instead of just the single mismatched key.Relates: #76542