Fix memory/breaker leaks for outbound responses (#76474) #76536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outbound responses would not get the expected `decRef`, resulting in memory and/or circuit breaker leaks. In particular, the `GetCcrRestoreFileChunkResponse` expects this, causing a leak when a follower bootstraps. Relates elastic#65921
henningandersen
added
>bug
:Distributed Coordination/Network
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
added a commit
that referenced
this pull request
Aug 15, 2021
Outbound responses would not get the expected `decRef`, resulting in memory and/or circuit breaker leaks. In particular, the `GetCcrRestoreFileChunkResponse` expects this, causing a leak when a follower bootstraps. Relates #65921
lchqlchq
pushed a commit
to lchqlchq/elasticsearch
that referenced
this pull request
Aug 23, 2023
lchqlchq
pushed a commit
to lchqlchq/elasticsearch
that referenced
this pull request
Aug 23, 2023
…elastic#76536" This reverts commit 411e5e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76474
Outbound responses would not get the expected
decRef, resulting inmemory and/or circuit breaker leaks. In particular, the
GetCcrRestoreFileChunkResponseexpects this, causing a leak whena follower bootstraps.
Relates #65921