Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mutable Data Structure in SnapshotsInProgress #76505

Merged

Conversation

original-brownbear
Copy link
Member

The feature info instances are part of the CS and shouldn't be mutable to prevent accidental bugs down the line.

The feature info instances shouldn't be mutable to prevent accidental bugs down the line.
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@original-brownbear
Copy link
Member Author

Thanks Artem!

@original-brownbear original-brownbear merged commit 83afe88 into elastic:master Aug 13, 2021
@original-brownbear original-brownbear deleted the fix-sn-feature-info branch August 13, 2021 17:16
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 14, 2021
The feature info instances shouldn't be mutable to prevent accidental bugs down the line.
original-brownbear added a commit that referenced this pull request Aug 14, 2021
The feature info instances shouldn't be mutable to prevent accidental bugs down the line.
@original-brownbear original-brownbear restored the fix-sn-feature-info branch April 18, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants