Changes to keep Checkstyle happy after reformatting #76464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>refactoring
v8.0.0
:Delivery/Tooling
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Aug 17, 2021
| @@ -169,6 +169,12 @@ dependencies { | |||
| String grammarPath = 'src/main/antlr' | |||
| String outputPath = 'src/main/java/org/elasticsearch/painless/antlr' | |||
|
|
|||
| spotless { | |||
| java { | |||
| targetExclude "${outputPath}/*.java" | |||
There was a problem hiding this comment.
Ug, we really should be putting generated source elsewhere instead of mixing it with the main sourceset. Let's add a TODO here.
|
I just remembered, should we follow up and add this to |
I see why we might do that, but I've edited config files as well, and I'd still want those changes to show up in |
pugnascotia
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Aug 18, 2021
* Reformatting to keep Checkstyle after formatting * Configure spotless everywhere, and disable the tasks if necessary * Add XContentBuilder helpers, fix test
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a number of tweaks to the source so that in the future, after a complete reformat with Spotless, Checkstyle is still happy with the code.
Also:
MachineLearningGetResultsITsince it was unreadable.XContentBuilderthat will format better