Name BulkItemResponse ctors
#76439
Merged
Name BulkItemResponse ctors
#76439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>non-issue
:Distributed Indexing/CRUD
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
`BulkItemResponse` can contain either a success or failure. This replaces the two constructors used to build either case with named static methods. So instead of ``` return new BulkItemResponse(0, OpType.CREATE, createResponse); return new BulkItemResponse(0, OpType.CREATE, failure); ``` you now use ``` return BulkItemResponse.success(0, OpType.CREATE, createResponse); return BulkItemResponse.failure(0, OpType.CREATE, failure); ``` This makes it marginally easier to read code building these things - you don't have to know the type of the parameter to know if its a failure or success.
nik9000
commented
Aug 12, 2021
| private Failure failure; | ||
|
|
||
| BulkItemResponse() {} | ||
| private final Failure failure; |
There was a problem hiding this comment.
This all started with me wanting to make these final to make them easier to reason about.
arteam
approved these changes
Aug 12, 2021
| this.id = id; | ||
| this.response = response; | ||
| this.opType = opType; | ||
| this.failure = failure; |
There was a problem hiding this comment.
I think it makes sense to add an assertion here that either response or failure needs to be set, but not both.
|
Thanks for reviewing @arteam. |
nik9000
added
auto-backport
💔 Backport failed
To backport manually run |
|
Manual backport incoming. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 12, 2021
`BulkItemResponse` can contain either a success or failure. This replaces the two constructors used to build either case with named static methods. So instead of ``` return new BulkItemResponse(0, OpType.CREATE, createResponse); return new BulkItemResponse(0, OpType.CREATE, failure); ``` you now use ``` return BulkItemResponse.success(0, OpType.CREATE, createResponse); return BulkItemResponse.failure(0, OpType.CREATE, failure); ``` This makes it marginally easier to read code building these things - you don't have to know the type of the parameter to know if its a failure or success.
|
High touch backport! Just about every line conflicted because master doesn't have types. Fun. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 12, 2021
`BulkItemResponse` can contain either a success or failure. This replaces the two constructors used to build either case with named static methods. So instead of ``` return new BulkItemResponse(0, OpType.CREATE, createResponse); return new BulkItemResponse(0, OpType.CREATE, failure); ``` you now use ``` return BulkItemResponse.success(0, OpType.CREATE, createResponse); return BulkItemResponse.failure(0, OpType.CREATE, failure); ``` This makes it marginally easier to read code building these things - you don't have to know the type of the parameter to know if its a failure or success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BulkItemResponsecan contain either a success or failure. Thisreplaces the two constructors used to build either case with named
static methods. So instead of
you now use
This makes it marginally easier to read code building these things - you
don't have to know the type of the parameter to know if its a failure
or success.