Fix eclipse compilation after plugin spi #76437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
Painless extensions now compile against it's `spi` subproject. Gradle and IntelliJ rig the dependencies correctly but Eclipse doesn't seem to manage it. This temporarily declares the `spi` as a `compileOnly` dependency when in Eclipse land so Eclipse can see the classes.
nik9000
added
auto-backport
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 13, 2021
Painless extensions now compile against it's `spi` subproject. Gradle and IntelliJ rig the dependencies correctly but Eclipse doesn't seem to manage it. This temporarily declares the `spi` as a `compileOnly` dependency when in Eclipse land so Eclipse can see the classes.
💚 Backport successful
|
nik9000
added a commit
that referenced
this pull request
Aug 13, 2021
Painless extensions now compile against it's `spi` subproject. Gradle and IntelliJ rig the dependencies correctly but Eclipse doesn't seem to manage it. This temporarily declares the `spi` as a `compileOnly` dependency when in Eclipse land so Eclipse can see the classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Painless extensions now compile against it's
spisubproject. Gradleand IntelliJ rig the dependencies correctly but Eclipse doesn't seem to
manage it. This temporarily declares the
spias acompileOnlydependency when in Eclipse land so Eclipse can see the classes.