-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML][Transform] fixing testFailureCounterIsResetOnSuccess test failure #76397 #76417
Merged
elasticsearchmachine
merged 1 commit into
elastic:master
from
benwtrent:test/ml-transform-issue-76397
Aug 12, 2021
Merged
[ML][Transform] fixing testFailureCounterIsResetOnSuccess test failure #76397 #76417
elasticsearchmachine
merged 1 commit into
elastic:master
from
benwtrent:test/ml-transform-issue-76397
Aug 12, 2021
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elastic#76397 There are two possible race conditions that were not previously handled in this test. - Since the syncconfig was null, it may be that the transform actually gets set to stopping/stopped and its unable to kick off another indexing pass - It may also be that the indexer thread is still finishing up work when the second execution is requested, so it returns false. Adding a sync config and assertBusy handles these cases. Ran 1k+ times locally with this change and it never failed. Without, it failed ~10 runs. closes elastic#76397
benwtrent
added
>test
Issues or PRs that are addressing/adding tests
v8.0.0
:ml/Transform
Transform
auto-backport
Automatically create backport pull requests when merged
v7.14.1
v7.15.0
labels
Aug 12, 2021
Pinging @elastic/ml-core (Team:ML) |
dimitris-athanasiou
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benwtrent
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Aug 12, 2021
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 12, 2021
…elastic#76397 (elastic#76417) There are two possible race conditions that were not previously handled in this test. - Since the syncconfig was null, it may be that the transform actually gets set to stopping/stopped and its unable to kick off another indexing pass - It may also be that the indexer thread is still finishing up work when the second execution is requested, so it returns false. Adding a sync config and assertBusy handles these cases. Ran 1k+ times locally with this change and it never failed. Without, it failed ~10 runs. closes elastic#76397
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 12, 2021
…elastic#76397 (elastic#76417) There are two possible race conditions that were not previously handled in this test. - Since the syncconfig was null, it may be that the transform actually gets set to stopping/stopped and its unable to kick off another indexing pass - It may also be that the indexer thread is still finishing up work when the second execution is requested, so it returns false. Adding a sync config and assertBusy handles these cases. Ran 1k+ times locally with this change and it never failed. Without, it failed ~10 runs. closes elastic#76397
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 12, 2021
…#76397 (#76417) (#76421) There are two possible race conditions that were not previously handled in this test. - Since the syncconfig was null, it may be that the transform actually gets set to stopping/stopped and its unable to kick off another indexing pass - It may also be that the indexer thread is still finishing up work when the second execution is requested, so it returns false. Adding a sync config and assertBusy handles these cases. Ran 1k+ times locally with this change and it never failed. Without, it failed ~10 runs. closes #76397
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 12, 2021
…#76397 (#76417) (#76422) There are two possible race conditions that were not previously handled in this test. - Since the syncconfig was null, it may be that the transform actually gets set to stopping/stopped and its unable to kick off another indexing pass - It may also be that the indexer thread is still finishing up work when the second execution is requested, so it returns false. Adding a sync config and assertBusy handles these cases. Ran 1k+ times locally with this change and it never failed. Without, it failed ~10 runs. closes #76397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:ml/Transform
Transform
Team:ML
Meta label for the ML team
>test
Issues or PRs that are addressing/adding tests
v7.14.1
v7.15.0
v8.0.0-alpha2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two possible race conditions that were not
previously handled in this test.
transform actually gets set to stopping/stopped
and its unable to kick off another indexing pass
finishing up work when the second execution is
requested, so it returns false.
Adding a sync config and assertBusy handles these
cases. Ran 1k+ times locally with this change
and it never failed. Without, it failed ~10 runs.
closes #76397