Clean up whitelist loading for core contexts in painless plugin #76392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@stu-elastic Thanks for the review! |
jdconrad
added a commit
that referenced
this pull request
Aug 13, 2021
This change creates a standard for loading additional allow listed elements for the core contexts within the ScriptPlugin. For each core context we look for org.elasticsearch.script.<context-name>.txt and if it exists we load it automatically for that context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a standard for loading additional allow listed elements for the core contexts within the ScriptPlugin. For each core context we look for
org.elasticsearch.script.<context-name>.txtand if it exists we load it automatically for that context.