-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of javadocs #76382
Merged
elasticsearchmachine
merged 2 commits into
elastic:master
from
rjernst:painless/fix_javadoc_gen
Aug 11, 2021
Merged
Fix generation of javadocs #76382
elasticsearchmachine
merged 2 commits into
elastic:master
from
rjernst:painless/fix_javadoc_gen
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The javadoc generation for painless api classes was broken by a recent commit. This commit fixes it by correct the classpath used to run the javadoc task. Additionally, the task is added to `check` to ensure it runs with CI. closes elastic#76373
rjernst
added
>non-issue
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
v7.15.0
labels
Aug 11, 2021
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
added
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
auto-backport
Automatically create backport pull requests when merged
labels
Aug 11, 2021
jdconrad
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine test this |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 11, 2021
The javadoc generation for painless api classes was broken by a recent commit. This commit fixes it by correct the classpath used to run the javadoc task. Additionally, the task is added to `check` to ensure it runs with CI. closes elastic#76373
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
>non-issue
Team:Core/Infra
Meta label for core/infra team
v7.15.0
v8.0.0-alpha2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javadoc generation for painless api classes was broken by a recent
commit. This commit fixes it by correct the classpath used to run the
javadoc task. Additionally, the task is added to
check
to ensure itruns with CI.
closes #76373