Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IndexSnapshotsServiceIT and SnapshotsRecoveryPlannerServiceTests #76351

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Fix IndexSnapshotsServiceIT and SnapshotsRecoveryPlannerServiceTests #76351

merged 1 commit into from
Aug 11, 2021

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Aug 11, 2021

Closes #76343

A couple of silly mistakes on these tests.

@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. auto-backport Automatically create backport pull requests when merged v7.15.0 labels Aug 11, 2021
@fcofdez fcofdez requested a review from DaveCTurner August 11, 2021 12:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

arteam
arteam approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fcofdez fcofdez merged commit 7d65d83 into elastic:master Aug 11, 2021
@fcofdez
Copy link
Contributor Author

fcofdez commented Aug 11, 2021

Thanks Artem!

fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Aug 11, 2021
@fcofdez
Fix IndexSnapshotsServiceIT and SnapshotsRecoveryPlannerServiceTests
fb5b6fb 
Closes elastic#76343
Backport of elastic#76351
@fcofdez fcofdez mentioned this pull request Aug 11, 2021
Merged
fcofdez added a commit that referenced this pull request Aug 11, 2021
@fcofdez
Fix IndexSnapshotsServiceIT and SnapshotsRecoveryPlannerServiceTests (#…
28d6c89 
…76359)

Closes #76343
Backport of #76351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arteam arteam arteam approved these changes

@DaveCTurner DaveCTurner Awaiting requested review from DaveCTurner

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.15.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
4 participants
@fcofdez @elasticmachine @arteam @jakelandis