Refresh after force-merge #76345
Merged
Refresh after force-merge #76345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today a force-merge will write out the newly-merged segments and then flush them, but it does not automatically release the segments from before the merge. This will retain extra data on disk until the next refresh, which could be a long time away if the user has disabled periodic refreshes or is not searching the index frequently. With this commit we change the behaviour always to refresh after a force-merge. Closes elastic#74649 Backport of elastic#76221
DaveCTurner
added
>enhancement
:Distributed Indexing/Engine
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
So this is a bit different in 7.x because of synced-flush. In particular we already refresh the internal searcher in |
henningandersen
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a force-merge will write out the newly-merged segments and then
flush them, but it does not automatically release the segments from
before the merge. This will retain extra data on disk until the next
refresh, which could be a long time away if the user has disabled
periodic refreshes or is not searching the index frequently.
With this commit we change the behaviour always to refresh after a
force-merge.
Closes #74649
Backport of #76221